Michael Bromley comments

Results 750 comments of


                                            Michael Bromley

Typescript 3.7+ `useDefineForClassFields` flag may break Vendure `BaseEntity` initialization

Hi @pleerock thanks for stopping by! And yeah I guess we might need to eventually re-think how we handle this at some point.

Dashboard: There is no channel block on the product page.

Thanks for these reports you've been making! I'm assigning several to our team for the next patch.

feat(dashboard): Add internationalization for Romanian language

Hi! Thanks for this contribution! Unfortunately in the mean time some other translation stuff got merged which has made a bunch of conflicts. Would you be able to take a...

feat(dashboard): Implement dragging to reorder collections

Please ensure that non-top-level collections can also be reordered within their parent.

fix(dashboard): Support localized decimal separator in tax rate input

@starry-osean thanks for quickly responding to the feedback! @gabriellbui from our team will be reviewing and testing this in the coming week 👍

fix(unit-test): Document fix to run Vendure tests on Mac and add rollup

Hi, are you able to provide any more context around why `rollup` is required to be added to the root package.json?

fix(unit-test): Document fix to run Vendure tests on Mac and add rollup

Hi Marc, Thanks for the explanation. Looks good to merge but would you be able to rebase onto the latest master first as there is now a conflict in the...

fix(unit-test): Document fix to run Vendure tests on Mac and add rollup

Thanks. All tests passing so I'm happy.

Channel aware customers & users (email address conflicts)

Relates to #1329

Transformed value not returned on save

@itse4elhaam Hi, Thanks for your feedback. As stated in the automated message - we needed to somehow get a signal on the actual important issues after years of inactivity had...