Michael Bromley

Results 750 comments of Michael Bromley

> Is there a way for me to build this PR and use them in my backend ? as i don't think linking this PR to my backend is the...

@rein1410 thank you for this excellent & thorough PR, and thanks @Draykee for your input šŸ‘

https://github.com/typeorm/typeorm/pull/10933/ is merged

I tested this locally and the e2e tests are all working just fine. I have no idea what was going wrong in CI. Thanks for your contribution!

@brunoslalmeida sorry for the slow reply. I added the "contributions welcome" label. In terms of the actual solution, we need to take into account the configured [MoneyStrategy.precision](https://docs.vendure.io/reference/typescript-api/money/money-strategy/#precision) setting. This is...

Thank for the report. This would be a good use case for channel-aware custom fields (#490) which have not yet been implemented because I've not arrived at a satisfactory design...

### Idea: `Struct` custom field type I've had this idea for a while: a new type for custom fields which is named "struct". The naming open for debate - there...

Notes on naming (one of the 2 hard things...) - "**object**": I started using this because it is well-known and simple. But upon implementing the various types, I started to...

@jyling as discussed on the livestream and further in Discord, we won't be implementing support for nested structs. Summary of the reasons: - Significantly increased complexity of implementation both in...

> By the way, since this feature essentially involves a JSON structure in the database, how should we handle migrations when there are changes to the structure of the custom...