Michael Bromley comments

Results 750 comments of


                                            Michael Bromley

add email event UI triggers for resend option in emails

Status update from my side: I pulled this PR locally and tested it out. Basically it looks good but I have a few points I want to spend more time...

add email event UI triggers for resend option in emails

Just an update as I am going through old PRs this morning: this is still on our "under consideration" lane in the roadmap. For now we have other higher priority...

Process crashes with: Cannot create a string longer than 0x1fffffe8 characters

Yes, a large multi tenant Nx monorepo.

Incorrect EntityId column types and missing foreign keys

Hi, thanks for the report. This would indeed be a breaking change but you are totally correct, we should use `'uuid'` rather than `'varchar'`. I've added this to "planned" but...

Add a function to manually send or resend (EmailEventHandler trigger) email to the UI for Order and Customer

Hi Eugene, Thanks for this thoughtful suggestion. I agree that it would be good to support the ability to re-send emails. Here are my first thoughts based on the outline...

fix: fix up saving lazy many to one relation with existing entities

Hi, I just checked out this PR locally and the strange thing is, when I comment out the change to ColumnMetadata.ts, the tests still pass. Then I even added `expect(false).to.equal(true)`...

Text message plugin

Hi! Would it make sense to make text messaging a capability of the email plugin? I know the naming will then be wrong, but purely in terms of the technical...

Text message plugin

@dlhck yes it would definitely need renaming in that case. Which is fine long-term. We'd need to think about how to minimize the breaking change for existing users of the...

Text message plugin

@dlhck yes that's a possibility. We could take that opportunity to fix a bunch of other design issues with the current plugin - e.g. a better API for extending handlers,...

throw new QueryRunnerAlreadyReleasedError()

Hi, The solution should not be to remove the `@Transaction()` decorator, since we _do_ generally want mutations to run inside transactions. I'm not sure how it is that running the...