Marcus Gartner
Marcus Gartner
@DrewKimball mind taking one more quick look?
Friendly ping @DrewKimball. :)
TFTR! bors r+
Let's assume #127219 is the fix and close this issue.
@wuhuua I'm going to close this issue for now. Please feel free to open a new issue (or reply to this issue) if you have further questions.
*[`pkg/sql/opt/optbuilder/routine.go` line 231 at r13](https://reviewable.io/reviews/cockroachdb/cockroach/129720#-O8d6xf270zb0dQxK7pz:-O8dAvwiCerUj1rxTybK:b-oozb2x) ([raw file](https://github.com/cockroachdb/cockroach/blob/04000199b659ace65c592d0ebacbd7cfb64986f1/pkg/sql/opt/optbuilder/routine.go#L231)):* Previously, mgartner (Marcus Gartner) wrote… We need to reset the user back to what it was previously after building the body of the...
I've added one of the commits from https://github.com/cockroachdb/cockroach/pull/129050.
*[`pkg/sql/opt/optbuilder/locking.go` line 280 at r1](https://reviewable.io/reviews/cockroachdb/cockroach/129768#-O5Pghc68Ae0KbfyQg3S:-O5Phqoz1JszTN1_NbF6:bmsepgk) ([raw file](https://github.com/cockroachdb/cockroach/blob/6a2d151cedbe01cd9d0e77d7581712e62a1639c7/pkg/sql/opt/optbuilder/locking.go#L280)):* Previously, mgartner (Marcus Gartner) wrote… nit: add this method to avoid the potential colset allocations and slightly costly iteration over a large set:...
@DrewKimball Don't forget to manually backport to 24.2 and 23.2, if that is still necessary.