Marcus Gartner

Results 114 comments of Marcus Gartner

*: rename SQL Stats

The cluster settings for SQL activity stats also use the same namespace, `sql.stats`, as table statistics cluster settings: Table statistics: Setting | Type | Default | Description -- | --...

*: rename SQL Stats

This also affects metric names: https://github.com/cockroachdb/cockroach/blob/2fdc0a62df08829dd96901fffb5fb1fbb0b0997d/pkg/sql/exec_util.go#L1031-L1084

sql: support UDFs with named args, strictness, and volatility

TFTRs! bors r+

sql: support UDFs with named args, strictness, and volatility

bors r+

sql: support UDFs with named args, strictness, and volatility

bors r-

sql: support UDFs with named args, strictness, and volatility

bors r+

sql: support UDFs with named args, strictness, and volatility

bors r+

sql: support UDFs with named args, strictness, and volatility

bors r+

sql:Hoist project session flag and support session settings in opt tests

@msirek it'd be ideal to get this PR and backports merged today so that the fixes can make it into the next 22.1 and 21.2 releases. The most pressing is...

sql:Hoist project session flag and support session settings in opt tests

*[`pkg/sql/opt/testutils/opttester/opt_tester.go` line 286 at r10](https://reviewable.io/reviews/cockroachdb/cockroach/85935#-NAAkzAc8NNZ8M9CYXJo:-NABdSGS2znTgO4K04uA:b-l70iha) ([raw file](https://github.com/cockroachdb/cockroach/blob/f22ca3d6e60458e91c32c4d52ca601c4b9ec9492/pkg/sql/opt/testutils/opttester/opt_tester.go#L286)):* Previously, msirek (Mark Sirek) wrote… OK, I picked the first option. I have seen reference cycles elsewhere. For example, `norm.Factory` -> `funcs` (`norm.CustomFuncs`)...