Marcus Gartner

Results 114 comments of Marcus Gartner

This has only failed once (I don't see any links to duplicate failures). I'm going to close and if it starts to reproduce more often then we can address it.

The tests were originally failing due to the minor bug https://github.com/cockroachdb/cockroach/issues/141593 which I've added an exception for. Now they are failing due to mismatched row count estimates in the output...

I've tried to remove the DBCert tests but CI is failing: ``` Error: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project sqlancer: No tests were executed! (Set -DfailIfNoTests=false to ignore...

*[`-- commits` line 10 at r1](https://reviewable.io/reviews/cockroachdb/cockroach/129477#-O5-_ZDd2-ZAT9W4rhHb):* Previously, michae2 (Michael Erickson) wrote… I'm curious what you mean here. I suspect I'm not completely understanding your argument. For a sequence of events...

Friendly ping @michae2 :)

> Is there something preventing sessions from also sharing the planCosts via the query cache? If planCosts are also shared, it might be possible for total planning costs for the...

TFTR and the ideas! bors r+

I realized this is related to #108360. I'll have a follow-up PR to address a few more things I found (mentioned in that issue).

I actually need to do the follow-up work in this same PR to get the tests to pass. We need to represent a `CHAR(N)` type with no type width in...

I had to adjust some of the UDF resolution logic to find overloads with `CHAR`, `CHAR(N)`, or `BPCHAR` parameters with any three of those variations. The behavior now matches Postgres...