cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

release-24.2: opt: disable `GenerateParameterizedJoin` when forcing custom plans

Open blathers-crl[bot] opened this issue 1 year ago • 2 comments

Backport 1/3 commits from #129050 on behalf of @mgartner.

/cc @cockroachdb/release


opt: disable GenerateParameterizedJoin when forcing custom plans

The exploration rule GenerateParameterizedJoin is now disabled when the plan_cache_mode session setting is set to force_custom_plan. This prevents possible regressions in plans for this mode in the rare case that a stable function is not folded during normalization (due to an error encountered during folding). In most cases, the check for placeholders and stable functions in GenerateParameterizedJoin is sufficient for preventing the rule from firing when a generic query plan is not being built—before optimizing a custom plan placeholders are always replaced with constants and stable functions are usually folded to constants.

Epic: None

Release note: None


Release justification: Reduce risk of new feature.

blathers-crl[bot] avatar Aug 22 '24 19:08 blathers-crl[bot]

Thanks for opening a backport.

Please check the backport criteria before merging:

  • [ ] Backports should only be created for serious issues or test-only changes.
  • [ ] Backports should not break backwards-compatibility.
  • [ ] Backports should change as little code as possible.
  • [ ] Backports should not change on-disk formats or node communication protocols.
  • [ ] Backports should not add new functionality (except as defined here).
  • [ ] Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • [ ] All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport policy.
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • [ ] There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • [ ] The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • [ ] New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • [ ] The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • [ ] Your backport must be accompanied by a post to the appropriate Slack channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this backport.

blathers-crl[bot] avatar Aug 22 '24 19:08 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar Aug 22 '24 19:08 cockroach-teamcity

TFTR!

mgartner avatar Aug 30 '24 19:08 mgartner