Marcus Gartner

Results 114 comments of Marcus Gartner

I thought this was definitely the issue I was having, but after deploying the fix, I experienced the same hang in the stream only a few days later. I don't...

@DrewKimball Should this be backported to the 22.2.0 branch? SQLancer might be running into the bug: https://github.com/sqlancer/sqlancer/pull/587#issuecomment-1281468873

Good point. They aren't a huge problem, we can ignore them in SQLancer until v22.2.1 is released.

Reduced reproduction: ``` statement ok CREATE TABLE t ( a INT, b INT, c INT, INDEX (a, c) ); statement ok SELECT NULL FROM t WHERE a IN ( SELECT...

This occurs on v22.1.6, so this is not a release blocker.

The problem is that we incorrectly determine that an index used for a lookup join is non-covering when a column in the ON filter is not in the index and...

This is easier to fix than I originally thought. Will have a PR up momentarily.

Since this is a performance improvement, let's wait to backport until 22.2.1. I haven't review this yet, but I'll take a look in the next day or so.

If there was no Limit, then that's a full table scan, so it's not a case that's ever going to be very fast. But even if there's some real-world case...