Marcus Gartner
Marcus Gartner
> Which backport releases do you think are appropriate? I think 22.2 would be good.
It might be good to backport this into v22.2.1 so I've added the label.
@fqazi Do you have reproduction steps for this?
Yahor says it's difficult to reproduce, but it's possible to fake an error to see the problems this creates.
Great find! This is a bad one. I want to take some time to audit all these casts - any cast that has to read some mutable state should not...
No, I can fix that now, I think.
I'll point out that the pattern of swallowing an evaluation error is used in other cases: https://github.com/cockroachdb/cockroach/blob/31ffb42b585d0b196a438cddfdae56b28ff0e674/pkg/sql/opt/norm/fold_constants_funcs.go#L469-L472 https://github.com/cockroachdb/cockroach/blob/31ffb42b585d0b196a438cddfdae56b28ff0e674/pkg/sql/opt/norm/fold_constants_funcs.go#L514 https://github.com/cockroachdb/cockroach/blob/31ffb42b585d0b196a438cddfdae56b28ff0e674/pkg/sql/opt/norm/fold_constants_funcs.go#L618-L621 The reason we can do this is because we only try...
*[`pkg/sql/opt/exec/execbuilder/testdata/tpch_vec` line 978 at r2](https://reviewable.io/reviews/cockroachdb/cockroach/85871#-N97uRgN4mkSppVS6gSM:-N995NKD0MYuItaQYwbm:bn2xm1p) ([raw file](https://github.com/cockroachdb/cockroach/blob/55a604297d32cf620063ecc1013cbbfe1fb9d33a/pkg/sql/opt/exec/execbuilder/testdata/tpch_vec#L978)):* Previously, msirek (Mark Sirek) wrote… OK. Is there a way to set a session var in a rules test? I am getting error...
Can we make a thorough list of all the places that the statement / transcation statistics are named with some form of `stats` or `statistics`? A rough brainstorm: * The...