cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

xform: make FoldDivOne an essential normalization

Open msirek opened this issue 2 years ago • 1 comments

Fixes #86790

This fixes sqlsmith errors caused by differences in the number of displayed digits right of the decimal place for expression / 1 by making the folding of this expression essential.

Release note: None

msirek avatar Sep 22 '22 17:09 msirek

This change is Reviewable

cockroach-teamcity avatar Sep 22 '22 17:09 cockroach-teamcity

Build succeeded:

craig[bot] avatar Sep 23 '22 16:09 craig[bot]

Which backport releases do you think are appropriate?

I think 22.2 would be good.

mgartner avatar Sep 26 '22 14:09 mgartner

blathers backport release-22.2

msirek avatar Sep 26 '22 16:09 msirek

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 956948ed0ba3a76bcfbd607d55985924d2b9233e to blathers/backport-release-22.2-88485: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-22.2 failed. See errors above.


:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

blathers-crl[bot] avatar Sep 26 '22 16:09 blathers-crl[bot]