Chris Stackhouse
Chris Stackhouse
[ARMBlockingComment] @sunkun99 - Please fill out the intake form above.
> "tags": { Same here. Since this is on a proxy resource, you need to rename this property to something else and move it into the property bag. --- Refers...
> "tags": { Rename and move into the property bag. --- Refers to: specification/offazurespringboot/resource-manager/Microsoft.OffAzureSpringBoot/preview/2023-01-01-preview/springbootdiscovery.json:1457 in 78d7fb5. [](commit_id = 78d7fb5a951500f62bfdb1018eae207cf37df357, deletion_comment = False)
> "springbootappsProperties": { Removing the "siteName" property is a breaking change. --- Refers to: specification/offazurespringboot/resource-manager/Microsoft.OffAzureSpringBoot/preview/2023-01-01-preview/springbootdiscovery.json:1488 in 78d7fb5. [](commit_id = 78d7fb5a951500f62bfdb1018eae207cf37df357, deletion_comment = False)
@sunkun99 - Your later changes have introduced breaking changes. I've identified those in PR comments and added the label to route your PR to breaking change review.
> "tags": { There are two separate issues with this property. The property name and its location. Your own tags implementation will absolutely not be allowed at the top-level of...
> "tags": { Same here: this needs to move to the property bag at minimum. --- In reply to: [1886036819](https://github.com/Azure/azure-rest-api-specs/pull/27229#issuecomment-1886036819) [](http://example.com/codeflow?ancestors=1886036819) --- Refers to: specification/offazurespringboot/resource-manager/Microsoft.OffAzureSpringBoot/preview/2023-01-01-preview/springbootdiscovery.json:1457 in 78d7fb5. [](commit_id = 78d7fb5a951500f62bfdb1018eae207cf37df357,...
> > @sunkun99 based on the discussion above , please note the following : > > > > * Having a top level tags properties for a ProxyResource is not...
> @raosuhas , @mentat9 > > As per our product plan, we want to implement properties.tags now before ARM releases TagsV2. We don't want to introduce a tags-like name now...
> Lets call the TagsV2 rolled out time as T2. Lets call the time between now and T2 as T1. > > In T1, Properties.Tags will get copied to ARG...