Matt Solomon

Results 519 comments of Matt Solomon

I don't think we necessarily need to close it, perhaps just refactor to put the logic as a flag instead of a separate command? I agree the `--use` and `--no-auto-detect`...

> a general usage is limited due to some assumptions and limitations regarding encoding, but it is definitely useful and we should add that What limitations are these? Also @odyslam...

@jferas pointed out to me this happens with another address too: https://github.com/foundry-rs/foundry/blob/71541ee0c27908e4e90b979f8501149085afa65d/evm/src/executor/mod.rs#L108-L115 I wonder if instead the right solution is to exclude these addresses from the fuzzer dict? 0x3fAB184622Dc19b6109349B94811493BF2a45362 definitely...

Yep, thanks. Interestingly, @jferas and I both did not see fuzz failures with either of those two addresses until recently, but I don't recall seeing a change that would cause...

> Hmm, I think `self.sender` and `self.test_address` could both be valid inputs(?) and should not be excluded. Yea I think I lean this way also, just want to make sure...

Another reproduction case: try verifying that the EVM (L1) and OVM (L2) versions of the Uniswap V3 SwapRouter are equivalent: ```sh # Define URL for Optimistic Ethereum Node OE_RPC_URL=https://urlToOptimisticEthereumNode #...

It seems likely that the `hevm equivalence` failure in the previous comment is due to the fact that the contract at that address contains a `while (true)` loop that throws...

Once solution would also be updating from the current (very old) ethers v4 to ethers v5, which seems to handle not being provided the `tuple` keyword. Using the ethers CLI:...

+1 for blocknative's gas estimator, they're always great in my experience

Agreed on a free one, good point about the blocknative API key. Just tested/confirmed that https://api.txprice.com/ returns the same data as blocknative, so that seems to be a great option...