Matt Solomon

Results 519 comments of Matt Solomon

Of the 4 items listed in my above comment, I believe 1 and 2 are implemented, 3 and 4 are not.

+1 on @devanonon's comment, haven't gotten around to opening issues yet but here's a related repro with other issues too: https://github.com/mds1/forge-trace-and-script-issue

+1 seems like a good idea to me, I never loved the default name of `Contract` for the same reason

> should probably just be its own thing although it seems @mds1 disagrees, don't have any strong opinion on this, it might just be a bit odd Sorry missed this,...

This is a good config option to add, e.g. `create2_deployer = 0x123...`. Alternative name ideas: `create2_deployer_contract` or `create2_factory`

The main reasons to use another create2 deployer are (1) pass init data to be called after deploy, (2) more leading zeros for cheaper deploy, and I think that's it?...

I think all of those are good ideas to include in a canonical create2 deployer contract 👌 Perhaps next week I can scaffold out a proposed interface

Proposed create2 deployer below, feedback welcome. Interfaces (and the code comments) are largely based on @0age's [create2 deployer](https://etherscan.io/address/0x0000000000FFe8B47B3e2130213B802212439497#code), with a few modifications based on the above. ```solidity contract Create2Deployer {...

What chain ID information did you have in mind? Another method that hashes your salt with chain ID to prevent redeploying to another chain at the same address might be...