Matt Solomon

Results 519 comments of Matt Solomon

I'd be ok with only supporting 0.8.x for now (and updating the `StdJson.sol` pragmas + CI as needed) and opening a separate issue to track supporting the `stdJson` lib for...

Ah nice, that is a great idea! Some thoughts: 1. I think it still will require some changes to CI anyway? (since we'll have a contract in this repo that...

@gakonst I don't think that helps since the decoding is done in the main `Test.sol` contract, not in the tests, e.g. check the failed CI here: https://github.com/foundry-rs/forge-std/runs/8059709854?check_suite_focus=true#step:6:38

Got it, so IIUC correctly the suggestion here is that: - Users might be writing contracts with solidity 0.6 or 0.7 - But, they can still write their tests in...

I [searched sourcegraph](https://sourcegraph.com/search?q=context:global+solc%28-%7C_%29version%5Cs*%3D%5Cs*%28%5C%22%7C%5C%27%290.%5Cd.%5Cd*%28%5C%22%7C%5C%27%29+file:foundry.toml&patternType=regexp) and found 112 repos that specify a solc version in `foundry.toml`. Of those 110 are 0.8.x and 2 are 0.7.x (nomad and beanstalk). I know Maker uses...

Sorry, catching up now. What's the proposed design here? Is it a >=0.8 lib, or an abstract contract? Using `pragma experimental ABIEncoderV2;` was a good idea and I support that...

My stack trace when seeing this error is different, as seen below: ``` Error: Returned error: Returned error: header not found at PromiEvent (node_modules/@truffle/contract/lib/promievent.js:9:30) at /Users/mds/Documents/projects//contracts/node_modules/@truffle/contract/lib/execute.js:223:26 at Function.new (node_modules/@truffle/contract/lib/contract/constructorMethods.js:57:53) at...

As an alternative to CLI publishing, can also consider a github workflow that publishes on merge to master. Whichever is simpler is ok with me

Hey @amritkumarj, just bumping the last few open comments. The branch is also now out of date with master 🙂

LGTM, thank you @amritkumarj! Do you mind resolving conflicts, then we should be good to merge once CI passes pending any comments from @apbendi. (CI will probably fail now, but...