Matt Solomon
Matt Solomon
Note that part of the scope of this issue involves changing broadcast artifacts such that txs/receipts are saved with the correct types to facilitate type inference when reading JSON. For...
I agree this is useful, but big +1 that this should not be part of forge. `forge inspect`'s purpose is to simply make solc output such as storage layout more...
Agreed, `--block ` is the syntax used elsewhere in cast which we should support here too
Right now `cast wallet vanity` is for vanity EOAs, or for contracts deployed with CREATE (contracts created with CREATE are a function of deployer address and nonce). `cast` currently has...
I think `cast wallet vanity --create2 `, and prints the salt and resulting contract address, could be a good syntax. That way it matches the cheat code, and both can...
Just curious as to why you prefer a wrapper method that uses ffi? IMO a cheatcode is preferable for common actions like this to avoid introducing the security risks of...
> +1, that's the most straightforward solution Happy to concede and go with that approach, but do want to understand why it's preferable given https://github.com/foundry-rs/foundry/issues/2359#issuecomment-1194767655 😅 Both the cast command...
Another idea here if people don't like the idea of a `vm.mineSalt` cheatcode is `vm.stopMeteringGas()` and vm.resumeMeteringGas()` cheatcodes. That way you can then do gas-intensive things like mine a salt...
This is great! Will defer to @onbjerg and @mattsse on implementation, just wanted to add some comments around UX suggestions: In https://github.com/foundry-rs/foundry/issues/1131, I pictured this being a subcommand of `build`...
> Is this not the same as https://github.com/foundry-rs/foundry/issues/1131? The --sweep on forge test proposed in there would really mostly affect the build process, only minimal changes would be needed for...