Matt Solomon
Matt Solomon
I think we should update the address/avatar so that when clicked it shows something similar to what Uniswap does as shown below. All those features lgtm (except we don't need...
To start, perhaps we just only check against the address being withdrawn to simplify the logic
@garyghayrat looks like you assigned yourself to this, do you still want to work on it or should we reassign to @alexkeating? Re implementation, some thoughts: 1. Having a database...
Ah sorry, to clarify I mean: - Right now, signing a message only happens when you view a page that requires it, and I believe it happens lazily (i.e. we...
Ah nice find in MM! Yea I like the idea of just pulling in the code directly to keep dependencies down, and we can just link to the original sources...
Oops, guess even "partially resolves" is enough for GitHub to close a linked issue. Keeping this open until (2) is implemented
Ah this is really clever, thanks! Haven't seen that before. Adding the 1 byte of the ECDH key to the `Announcement` would reduce security by 1 byte though, right? In...
Related to 1 and 2, one idea is ensure the warning text makes it clear that if you mess up while using advanced mode funds may be unrecoverable, i.e. make...
Yea david and I chatted earlier, IMO we should close this issue and focus on #378 instead due to some trickiness above that doesn't seem worthwhile
Since we now use OZ everywhere, I think original scope of this issue is outdated and the issue can be closed. But we don't have support for properly handling replacement...