Matt Solomon
Matt Solomon
Some issues the naming convention approach may cause: - forge-std has a test called `testSkip` to test it's `skip` helper method, so that will need to be renamed - Maker...
Based on existing tests it seems testSkip.* makes the most sense. Though I do feel a cheatcode would be simpler UX since it doesn't require remembering the nuances on the...
I still think this feature is useful in some cases. For example with hardhat, I'd sometimes scaffold out a bunch of unimplemented tests and mark them as skipped to signal...
Probably should have left this comment in this issue instead, so linking to it here https://github.com/foundry-rs/foundry/pull/2606#issuecomment-1205435913 > Ah good point, it would be nice to support contract-level skips too, but...
Some ideas on what `forge audit` should include below. IMO the scope of this command should be anything that can result in malicious software on your machine, which means this...
@gakonst Just curious, why not? I think counter can be an interesting template, because it leaves room to expand it and have `forge init` include a very simple test suite...
Proptest is largely unmaintained at this point. There hasn't been an update for over a year, though there is a fork that's made a few fixes—more info here: https://github.com/AltSysrq/proptest/issues/268 I...
> 4byte doesn't capture whether a field is indexed or not, so I'm needing to merge all those topics in with data and treat them as unindexed. Do you see...
I'd say first try looking for an `implementation()` method and if it exists, use what it returns. If that method doesn't exist,then fall back to the EIP-1967 slot that you...
Just summarizing what we ended up on as the path forward: 1. Remove Optimism from the `has_different_gas_calc` function https://github.com/foundry-rs/foundry/blob/112bd440c7cc83480612c5e05d71229ceeba7178/cli/src/cmd/forge/script/broadcast.rs#L275-L277 https://github.com/foundry-rs/foundry/blob/123ad0a427dc938a0a911eae3332de6576370a51/cli/src/cmd/utils.rs#L199-L205 2. Force `--slow` on Arbitrum and Optimism. Both of don't...