Matt Solomon

Results 519 comments of Matt Solomon

That all makes sense, but why is the regular pipeline able to handle this, and not the IR pipeline? Presumably the regular pipeline is not just incorrectly assuming all assembly...

I believe `include_storage` is still being respected, but the address is being added to the dictionary simply because it exists in the vm database (outside of contract storage), see here:...

Just wanted to bump this and see if there are plans to get this merged anytime soon :)

`forge coverage` runs with no optimizer / no via-ir enabled, so if you were normally using via-ir, this would result in some [semantic changes](https://docs.soliditylang.org/en/latest/ir-breaking-changes.html#semantic-only-changes), but I don't think that should...

Would the UX specified in https://github.com/foundry-rs/foundry/issues/2551 and https://github.com/foundry-rs/foundry/issues/2552 meet your use case? Essentially failures get saved to JSON files and can be re-run by passing a path to that input...

If you run with `RUST_LOG=forge=trace,foundry_evm=trace,ethers=trace forge test ` you'll see this is just because it's making a lot of RPC requests since it's a fork test. If you pin to...

One way you can try to verify that tests are not hanging, and are simply slow due to the RPC queries is as follows: Modify your foundry config as follows:...

> but in the end, the test just sits there (aka it hangs) Can you clarify what you mean here? From what I can see it is running and making...

> it just sits in this screen forever. It doesn't complete the test. That's what I mean by "it hangs". Got it. So it will complete *eventually*, just slowly, due...

> I guess technically it is correct when running in forking mode that the sender account should be fetched via rpc, but I'm not sure if this is useful here....