Matt Solomon
Matt Solomon
Hmm interesting. It does feel unnecessary, as in practice I'd suspect most bugs surfaced by invariant testing are not due to differences in the sender. But I'm also not sure...
> so I suggest we insert an empty sender account into the database first? agreed it's not too useful, I think it'd be better to just change the default sender...
@cdgmachado0 If you want a workaround in the meantime just use `targetSenders()` to hardcode a list of 1 or more senders, that way random senders are not generated. You can...
> @mds1 I think both fixes would be pretty simple Sorry just to clarify, this is just a single solution that would behave as follows: - Define 5-10 default random...
One thing we also should figure out is how can scripts be used in a non-interactive/test environment with this cheat. It's best practice to test scripts, and many use scripts...
> @mds1 would you like me to implement https://github.com/foundry-rs/foundry/issues/2399 as part of this PR? Should be simple enough I think. Dialoguer supports a confirm-type prompt: > https://docs.rs/dialoguer/latest/dialoguer/struct.Confirm.html I would do...
> shall we just filter out view & pure functions? I don't know if we want to do this, as it forces people to use the `assertEq` helpers and no...
Sorry, thought I responded here and I definitely remember writing something up... > This is a breaking change for test functions already declared with return values but I don't think...
Yea, I'd say let's close for now and we can revisit in the future if we get more reports of this being a hassle
Right, so prior to EIP-3860 there was no size limit on creation code (initcode), and just a 24576 byte size limit on runtime code EIP-3860 went live in shangai so...