Matt Solomon

Results 519 comments of Matt Solomon

@gakonst mind re-opening this one? we fixed `cast keccak` but IMO should also review other methods that should accept both text or bytes

@tynes do you know offhand if this can be closed? I haven't been using cast much recently for strings/bytes so am not certain, but feel like you may be using...

@0xSyntellect Can you provide concrete steps to reproduce?

Simple way to reproduce: ```solidity import "forge-std/Test.sol"; contract Test5 is Test { function setUp() public { console2.log("Test5.setUp()"); } function test_FuzzVals(uint x) external { console2.log("Test5.test_FuzzVals()"); } } ``` As shown in...

cc @Evalir, I just verified this bug is still occurring on the latest nightly using the repro in https://github.com/foundry-rs/foundry/issues/3843#issuecomment-1402311583. Guessing this is a simple fix

> even though just fixing it could make everyone's CI or local runs extremely noisy as a default We already would show the logs if it was a regular test...

This migration could also be an opportunity to introduce a few breaking changes to cheats, such as: - https://github.com/foundry-rs/forge-std/issues/349#issuecomment-1510888015

cc @odyslam just added this to #3801

@snreynolds I recall from the foundry support telegram you also had this issue, wondering if you figured it out and it was user error or if there's a forge bug...

Related to https://github.com/foundry-rs/foundry/issues/748