Matt Solomon

Results 519 comments of Matt Solomon

Just curious as to why you prefer a wrapper method that uses ffi? IMO a cheatcode is preferable for common actions like this to avoid introducing the security risks of...

Hey, just curious what the latest on this issue is! As described in https://github.com/prettier-solidity/prettier-plugin-solidity/issues/454#issuecomment-811035472, one thing that always bugs me a bit is when function parameters are split on multiple...

LGTM overall, thanks @fvictorio! You've addressed this, but my one comment is: > Also, in this case we would split the params even if they would fit in print width...

I believe I'm having the same issue. Running `crytic-compile .` succeeds, but `slither .` fails. Using a foundry repo, tried `forge clean` + reinstalling deps but still seeing the problem....

Ah yes, I see they have the same `id`. I think this is related to what @montyly and @mattsse were discussing here: https://github.com/foundry-rs/foundry/issues/3450 Similarly I'm not too familiar with compilation...

Closed by https://github.com/foundry-rs/forge-std/pull/184

Hey @akrantz01 @Wilfred just wanted to see if we can resolve conflicts and get this merged :)

> So should we change this schema to accommodate something like `permit2 = new Permit2{salt: SALT, deployerCreate2: CREATE2_ADDRESS}();` This is not valid solidity and there is currently no plans to...

Copying some nice from https://github.com/foundry-rs/foundry/issues/4918 here, cc @shazow - Two new cheats: `vm.skip(bool skip)` and `vm.skip(bool skip, string calldata reason)`, where the latter prints a reason string - Ensure the...

I'm not clear on if there's any todo's here. There's also now the [`deriveKey` and `rememberKey`](https://github.com/foundry-rs/forge-std/blob/fc560fa34fa12a335a50c35d92e55a6628ca467c/src/Vm.sol#L158-L166) cheats that provide another way to use mnemonics, so going to close this. Happy...