Matt Solomon

Results 519 comments of Matt Solomon

Ah I'm `macos:amd64` so seems this isn't an issue with svm-rs builds then, thanks 🙂

Hmm, interesting. So once change is that ds-test is now imported using relative paths, which I'd think should help any remappings issues when installed in `node_modules` As for ds-test not...

cc @mattsse for more path questions 😅 perhaps our rationale in https://github.com/foundry-rs/forge-std/pull/198 and https://github.com/foundry-rs/forge-std/pull/200 for using relative paths for ds-test was wrong?

@mattsse I agree with your assessment, opened https://github.com/foundry-rs/forge-std/pull/210 to resolve. @maurelian can you test out installing forge-std at that commit?

Thanks! This is a great workaround, minimal UX hit 👌 I just want to see how #207 shakes out before merging this, it's possible there's a solc or svm-rs issue...

I think the mapping idea so users can add their own chains is interesting—if anyone wants to refactor into the mapping approach to see if that still has the slow...

Per some discussion in the foundry telegram, let's - refactor to mapping approach due to added flexibility (also nice that the keys to access chain data matches the expected keys...

One feature request to add to `forge lint` is an option for named imports, e.g. preferring `import {X} from "A.sol"` over `import "A.sol"`

Planning to test this week! Will update here afterwards

@mattsse Mind reopening this? We now have create2 support in cast, but don't actually have a forge cheatcode yet