Matt Solomon

Results 519 comments of Matt Solomon

- Took the default `fmt` values and defined them explicitly in `foundry.toml` (if left implicit, a contributor with their own config in `~/.foundry/foundry.toml` would end up applying their config instead...

> Actually, after further testing I'm seeing some changes in behavior when using commit [dc8d830](https://github.com/foundry-rs/forge-std/pull/184/commits/dc8d830d3af6f67758f793ce42572270fb0f41fb) when compared to f36dab2 > > [`testExitSwaps`](https://github.com/balancer-labs/balancer-v2-monorepo/blob/master/pkg/pool-weighted/test/foundry/WeightedMath.t.sol#L105) fails with too many `vm.assume` rejects. I imagine...

@nventuro Had some time on a flight without wifi so figured this was a good offline debug task. Here's what I found: ### testUpdateCachedRatios Below is a concrete test that...

I'll check this out and put a simple script together to test the distributions before and after to make sure things are good / the new complexity (new conditionals) are...

Ok @ZeroEkkusu I think this implementation looks good. > We should test it more in practice to make sure there are no errors. Did you plan on writing these? Wondering...

Awesome, thanks. Once we get #195 merged I want to do one more quick round of testing by pinging a few people again (since we made some additional changes), then...

Ok, this is _finally_ just about ready to be merged, and just updated the description to link the relevant new PRs. I'm going to test this once more on some...

Ok just tested in two repos: - First one had tests all passing - One had some failures, but these seem ok since they're due to `bound`, and some failures...

Thanks! Just assigned it to you, let me know if you have any questions:)

That's a good point, all other checks are privacy related whereas this would be lost funds. FWIW this is how we spec'd it out in #310, so my suggestion would...