Milos Djermanovic

ESLint v9.6.0 has been released: https://eslint.org/blog/2024/06/eslint-v9.6.0-released/ Please merge semver-patch PRs only until we determine whether or not a patch release is necessary.

There were no regressions reported, so this concludes the v9.6.0 release. We can resume merging semver-minor changes.

CI with ESLint v9 fails here: ``` ******> npm ls >/dev/null npm error code ELSPROBLEMS npm error invalid: [email protected] /home/runner/work/eslint-plugin-react/eslint-plugin-react/node_modules/eslint [email protected] /home/runner/work/eslint-plugin-react/eslint-plugin-react ├── @babel/[email protected] ├── @babel/[email protected] ├── @babel/[email protected] ├── @babel/[email protected]...

In https://github.com/jsx-eslint/eslint-plugin-react/pull/3759/commits/d8f31860a7b3198bf2ef5a180c11a7d61ccf13c5, https://github.com/jsx-eslint/eslint-plugin-react/pull/3759/commits/9a86bc84ced7ce3232c8ac7d7f101c27a44f3415 & https://github.com/jsx-eslint/eslint-plugin-react/pull/3759/commits/85eed3279f724f76742e8a585d12a4532240f9f3, I updated several tests where `output` was the same as `code` to use `output: null` to assert that there's no autofix expected. ESLint v9 RuleTester...

> yes, you'll need to update the peerDeps and devDeps ranges to include eslint 9. Done in https://github.com/jsx-eslint/eslint-plugin-react/pull/3759/commits/a1402a2d624f740ffc1a35ce03abaf3522ecebff & https://github.com/jsx-eslint/eslint-plugin-react/pull/3759/commits/cda54a334d82e8d440f254179680e53105c3b705. I expected the dev deps update to be problematic for...

Actually, it isn't okay everywhere in CI. `pretest` fails with: ``` Oops! Something went wrong! :( ESLint: 9.3.0 ESLint couldn't find an eslint.config.(js|mjs|cjs) file. ``` https://github.com/jsx-eslint/eslint-plugin-react/actions/runs/9157980135/job/25175410426?pr=3759#logs

All checks are green now, except for linting because it installs ESLint v9. Perhaps we could remove ESlint v9 from devDeps and update `.github/workflows/node-18+.yml` to install ESLint with `--save-dev` instead...

> For [5801156](https://github.com/jsx-eslint/eslint-plugin-react/commit/5801156c39469050595f83cf1ce145d720b00f6e), can we use something like messageId, so the text doesn't have to be duplicated? Sure, now I updated all tests to use `messageId` in https://github.com/jsx-eslint/eslint-plugin-react/pull/3759/commits/17c4df7495eb54b3a745bb4289e31f24b06e0f12. I was...

I see some commits from this branch are already merged into master. Anything else I could do to help finish eslint v9 support? I think the only remaining issue here...

For me locally, npm installs eslint v8. But in pretest CI, it installs eslint v9. Maybe because of this: https://github.com/jsx-eslint/eslint-plugin-react/blob/417e1ca292788c75618dc994b084c3a57c483fce/.github/workflows/node-pretest.yml#L15-L16 Perhaps we could remove it?