Greg Oledzki

Results 146 comments of Greg Oledzki

Hmm. How can we run against our code base? I tried adding the `sbt` plugin and it fails with: ``` sbt:scalac-scapegoat-plugin> scapegoat [info] [scapegoat] Removing scapegoat class directory: git/scapegoat/target/scala-2.13.1/scapegoat-classes [error]...

More than half of the warnings reported above are `VariableShadowing` which got fixed in #313 (I hope)

With current `master` we are at: > Errors 3 Warnings 89 Infos 19 vs. previous: > Errors 3 Warnings 109 Infos 19

After #322 and #325 we are at: > Errors 0 Warnings 52 Infos 19

Fresh run: # Scapegoat Inspections **Errors**: 0 **Warnings**: 42 **Infos**: 19 ## Report ### com.sksamuel.scapegoat.Feedback.scala:83 **Level**: Info **Inspection**: com.sksamuel.scapegoat.inspections.FinalModifierOnCaseClass Missing final modifier on case class Using case classes without final...

I cannot reproduce using latest `master` - as demonstrated in a unit test added in #432.

(Also let me take the chance to say "Thank you" for the great work in the repo. I am preparing for the exam myself and it's very helpful)

> java.lang.UnsupportedClassVersionError: com/puppycrawl/tools/checkstyle/api/AuditListener has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions...

I think this issue belongs to https://github.com/sksamuel/scapegoat instead