Greg Oledzki
Greg Oledzki
We are at Scala 2.11 to 2.13 right now (in `master`). If I read it right: https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html one can run Scala 2.11 code with Java 6 or Java 7. So...
Ah. Now I can see in https://github.com/json4s/json4s/blob/master/CONTRIBUTING.md that in 3.5 and master we require Java 8: > This branch requires Java 8+ for all Scala versions So my previous comment...
Out of curiosity - @magnolia-k - what do you refer to by old a new reflection API?
Also - the `else` line looks fishy to me: https://github.com/json4s/json4s/blob/master/core/src/main/scala/org/json4s/reflect/descriptors.scala#L60 Is it really meant to give absolute score of `-100` for the whole constructor or for that argument only. I...
I think your fix in #662 is right. I would need to spend time extracting to a minimal example without all these dependencies, but based on what I see now,...
I don't see any tests for `bestMatching` in https://github.com/json4s/json4s/blob/master/tests/src/test/scala/org/json4s/ReflectorSpec.scala
> Here are the methods which seem to consume most of the CPU: I guess these are actually not self-time, but nearly the whole time is spent in AWT/the actual...
@timmolter what's your view on this?
As of now, in `xchart/src/main` there are: - 190 commented out `System.out.println` statements (`find -name *.java -exec grep -H "System.out.println" {} \; | grep "//"`) - 11 not commented out...
Not sure what the problem was, but with current `develop` the following code works and generates a chart with embedded image: ```java XYChart chart = new XYChartBuilder().width(800).height(600).title("Title").xAxisTitle("X title").build(); chart.addSeries("series", Arrays.asList(1,...