Greg Oledzki

Results 146 comments of Greg Oledzki

@shanman190 Thanks for looking into this. I've set up a dedicated Gradle project for reproducing the issue with simple `gradlew init`: https://github.com/mccartney/rewrite-repro-4614-gradle/commit/f5b959e3b386b12ce84df29d5a5456ab5ee31b56 The Gradle build passes with and without this...

Also checked Groovy program in [tio.run](https://tio.run/##Sy/Kzy@r/P8/OSexuFjBtSIxtyAnVaGaS0FBobgksSQzWaEsPzNFITcxM08juKQoMy89OlYhsSi9WBOiCAgKgKIlOXka6h6pOTn5CuH5RTkp6jqa1iDpWq7a//8B): ``` class Example { static void main(String[] args) { println('Hello World',); } } ``` and it worked fine.

``` @Test void trailingCommaInMethodCall() { rewriteRun( groovy( """ System.out.println("Anwil Wloclawek", ) """ ) ); } ``` fails in `rewrite-groovy` the same way as original report.

FWIW, I've just tried the following test: ``` @Test void groovyStyleCastForInt() { rewriteRun( groovy( """ int value = 3 as int """ ) ); } ``` and it passes in...

I think we are good with this. Even with older versions (Scala 2.x.x) I don't recall any issue with JDK 8 incompatibility. At the same time - we need to...