Greg Oledzki
Greg Oledzki
https://api.slack.com/changelog/2021-10-rtm-start-to-stop
Wow. That's an enormous contribution. Thank you for spending the time. I'd need to spend more time on this, but immediate thoughts are: - I'd rather have smaller PRs, but...
Also - why would we care about binary compatibility between various versions of this library? I don't think we ever had before.
I don't mind at all. PR welcome!
With current code base it's not possible yet, as there's no Play JSON support for Scala 3 yet. https://github.com/playframework/play-json says: > Play JSON supports Scala 2.12 and 2.13.
The Travis failure is because of test secrets not being available for fork-based PRs.
(another contributor here) While I understand what you mean, I don't know enough of Akka to have some say. I suggest you create a PR. I'll review it - either...
Fails in Scala 2.13 because of the collection changes there. ``` [info] "...List(Attachment(..." was not equal to "...Vector(AttachmentField(..." (JsonMessagesDeserializationTest.scala:26) ``` I guess I need to re-think that test.
Is it still the case?
Looks like a duplicate of #432