Mateusz Mandera
Mateusz Mandera
Can this be closed, considering https://github.com/jonathanslenders/asyncio-redis/commit/f2ae63533491f311130dfb43e347814cb7055140 was merged?
> I feel like it might be more correct to instead remove them from the system bot realm, if that realm doesn't contain users beyond the system bots... but I'm...
I think it's worth noting in the commit message that the first commit is not strictly a refactor because the order of operations does get changed (the rate limiting logic...
As for the failing tests, I think that's just the change of the rate limiting function getting called in the last commit Tim added and we need a tweak like...
@zaharazod Thanks for submitting this! Can you explain what this does and why?
@ortholeviator What should be the status of this issue following #106?
@timabbott Added a feature level bump, plus some description in the changelog and zulip.yaml. Also pushed an extra commit with a retry mechanism in the frontend, though I'm not sure...
Sounds good, just tweaked some typos like `oldest`->`newest` in `changelog.md` etc. and bumped the FEATURE_LEVEL.
I think @maiiku is right here, looking at this code from `social_core.pipeline.user.user_details`: ``` field_mapping = strategy.setting('USER_FIELD_MAPPING', {}, backend) for name, value in details.items(): # Convert to existing user field if...
It seems to me that `user_details` should not overwrite user attributes with empty strings, so that might be the right change to make. But I don't know if the current...