asyncio-redis icon indicating copy to clipboard operation
asyncio-redis copied to clipboard

Function `asyncio_redis.Connection.create()` hangs if connection can't be established

Open vikt0rs opened this issue 6 years ago • 2 comments

If someone tries to create a connection to the wrong host (for example) function asyncio_redis.Connection.create() hangs forever and the user gets no error message.

From my side, it happens in _reconnect() method [0] because of the while True: loop - it has no exit condition on connection error and it retries connection attempts forever

[0] - https://github.com/jonathanslenders/asyncio-redis/blob/master/asyncio_redis/connection.py#L93

vikt0rs avatar Apr 26 '19 12:04 vikt0rs

Pull request https://github.com/jonathanslenders/asyncio-redis/pull/118 looks like a solution for this issue. @jonathanslenders - any hope that the PR will be merged someday?

vikt0rs avatar Apr 26 '19 13:04 vikt0rs

Can this be closed, considering https://github.com/jonathanslenders/asyncio-redis/commit/f2ae63533491f311130dfb43e347814cb7055140 was merged?

mateuszmandera avatar Feb 15 '20 18:02 mateuszmandera