Mateusz Mandera
Mateusz Mandera
@timabbott Yeah, that was addressed in the previous push, with that and a couple other notes in the latest comment above - https://github.com/zulip/zulip/pull/28828#issuecomment-1947562167 Pushed right now again to just fix...
Test cases and actually implementing encrypting and signing. And then allowing users to set their preferences and upload their public key. I suppose just adding test cases could make it...
I edited the "Start implementing pgp_sign_and_encrypt" commit to fix a silly mistake (it had `` except UserProfile.DoesNotExist: `` instead of `` except UserPgp.DoesNotExist: `` in line 31) and rebased.
I imagine the tests, for those unimplemented parts should simply assert that NotImplementedError will be raised?
@timabbott I made the suggested changes, within the first 3 commits. The to_user_ids path is back in build_email now. As for the " we'll need to be careful about the...
Next stage has been implemented: we move to using a new class - PGPEmailMessage, inheriting from django's EmailMultiAlternatives. When .sign() or .encrypt() methods get invoked, PGP-magic happens and we generate...
This should fully work (on the backend side) now. Encrypted/signed emails seem to be properly generated and sent. Some comments to perhaps help in review, about decision I made and...
Resolved conflict and cleaned up usage of a highly unnecessary method _cache_original_message() in PGPEmailMessage.
Still working on webapp fixes to `upload_quota_mib`, so that commit not ready to merge yet
Okay, webapp is fixed now, so should be good to review. I replied to things above and fixed the `upload_quota_mib` issue