Mateusz Mandera

I don't understand why CodeQL is complaining about logging a username :thinking:

@timabbott I think all these commits should be relevant, so rebase. Also added a fix for the thing from https://chat.zulip.org/#narrow/stream/31-production-help/topic/lots.20of.20emails.20w.2F.20error.20messages/near/1212636 at the end I think the CodeQL error can be...

@timabbott Ready for another round of review. Replied with some elaboration on the special auth subdomain page in https://github.com/zulip/zulip/pull/13924#discussion_r694124822 Regarding CodeQL and https://github.com/zulip/zulip/pull/13924#discussion_r676051716 > This isn't new in this PR,...

@timabbott Made changes to the logging and removed the user-facing "wrong subdomain" error. Is there anything remaining we want to do here?

@timabbott > > I don't understand the set of conditionals here. It might be better to reorder this logic so that the existing `dev_auth_enabled` conditional is just above this block,...

I started implementing a prototype with the new format for the `page_params.realm_authentication_methods` dict to have a concrete idea of what it should look like to be usable, which I pushed...

Now there are tooltips if the backend is disabled, telling you which plan you need:  Pushed a complete implementation with tests, only missing a `/help/` page at this point....

> Thanks! That screenshot doesn't look like our normal Tippy tooltip, though. Oh true, I think that should be `data-tippy-content` instead of a `title`. I just have to figure out...

Nevermind, that was easier than expected, just needed to add `tooltip_text=unavailable_reason`: 

@timabbott Pushed a commit to also have the event changed to the same format. And a API feature level bump. I can squash, if that sounds easier to review instead...