Mateusz Mandera
Mateusz Mandera
Lgtm with that one note above, seems to work as expected with manual testing in dev as well
@alya Tweaked the phrasing, sorry just noticed this got lost in the notifications
@alya Sure, it was just that second screenshot with the `Please [contact Zulip support](https://github.com/help/contact-support) if you have any questions or concerns.` phrasing, updated in the PR description too now. ...
@alya That footer was shown in the specific case of `{% elif admin_access and not has_active_plan %}`. Eliminated the duplication now to get rid of it if we have `sponsorship_pending`:...
> Thinking about this more -- should we be adding a new cron job, or just calling this function from the existing archive cron job? Hmm, I could see it...
But we probably don't want to grow a large amount of separate cronjobs, so might make sense to just lump these together if it reasonably makes sense
Ah, I forgot to update the commit message - fixed now. So I think this is just needs a decision whether to merge as-is with this being a separate cronjob...
I marked this with `integration review`, since that was missing and my understanding is that this might be ready to merge, with just the remaining open question in https://github.com/zulip/zulip/pull/22213#issuecomment-1164642062
Pushed commits with each requested change. > We should make the inactive_realm check before the inactive_user check in the social auth code path; it seems like if the realm is...
Fixed a conflict.