mark9064
mark9064
This is a complex one ```diff diff --git a/src/displayapp/screens/Notifications.cpp b/src/displayapp/screens/Notifications.cpp index 3a3f5f2b..9bf55067 100644 --- a/src/displayapp/screens/Notifications.cpp +++ b/src/displayapp/screens/Notifications.cpp @@ -156,6 +156,9 @@ bool Notifications::OnTouchEvent(Pinetime::Applications::TouchEvents event) { } else if (event ==...
From what I can see there are a couple questionable things happening - Paint receives touch events while the notification->paint transition is occurring (apps probably shouldn't receive touch events until...
Hmm, not sure about simulator breakage. Anyone know what's causing the issue is there? Is FreeRTOS not available?
(InfiniSim PR now ready)
Yeah I don't love the mutex either. The reason why I went with this is because when anything on the watch calls CurrentDateTime(), it should get the current time. At...
I'm totally happy with any implementation that results in up to date time, not attached to this one! It's worth knowing that the mutex is priority inverting though. I imagine...
In hindsight, you're totally right that a full refactor would be out of scope for this, I really appreciate your feedback and explanation. Resolving to go ahead with this and...
The idea makes a lot of sense and sounds good to me. I don't see anyway to avoid the name checks - we need each watchface to have a unique...
This service script is working perfectly for me so far :smile: . Had no success at all without it.
Thought I may as well calculate the required buffer length too. Fewer magic numbers