Marc-André Lafortune

Results 457 comments of Marc-André Lafortune

Can be optimized... https://github.com/ruby/ruby/pull/3987

In Ruby 3.0+, the performance difference will still exist but won't be as noticeable.

Running in the same issue, which is three-fold: 1) There is no `retry` option set by default. This is for `GET`, so I think there should be 2) No API...

I'd add a 4th item that initializing the connection would ideally be in its own method. Right now its in `initialize`, which makes monkeypatching quite horrible.

I hope the NaNoWriMo went well.

My opinion is that this is a misfeature. I can't quite see a good usecase for this feature (in Inky or Inky-rb).

FWIW, I've added automatic tests for Rails 3, 4 & 5. I didn't have anything special to do to make it work with either versions once my config was working...

@ryanwi As per the doc, for the CSS inlining use either `premailer` or `roadie`

Interesting PR. I only looked at it quickly and I'm not the final authority on this gem, but a few things come to mind: 1) this mixes independent changes (config...