Marc-André Lafortune comments

Results 470 comments of


                                            Marc-André Lafortune

fix raw tag parsing for multiple lines

As soon as a new Inky is released we can merge it in inky-rb...

<raw> tags don't support multi-line html

You should target `develop`. Note that I'm not a committer on `inky`; I'm not sure who the current maintainers are.

Why not generate .inky layouts?

Sounds like a good idea.

fix raw tag parsing to include multi-line html

Cool. Last thing: wouldn't it be best (and simpler) to put those tests as new cases? I imagine that the output from the gem and the original js package were...

fix raw tag parsing to include multi-line html

The `cases_spec` checks all examples in `cases/` and compares the output of the gem with the original tool. For the the `` specs, we can either do like you did...

fix raw tag parsing to include multi-line html

FWIW, I think the specs you edited predate the `cases/`

Arguments accessible by .always(), .done() and .fail() from jQuery.ajax()

:+1:

Arguments accessible by .always(), .done() and .fail() from jQuery.ajax()

As far as I'm concerned, the current doc is fine now (as @dmethvin points out). It wasn't at the time it was opened. I believe this issue is now resolved....

`@behaviour` and `@impl` should add runtime dependency

It makes sense that checking of behaviour match can be done outside of both the implementation and the spec files, I should have thought of that. I can definitely have...

`@behaviour` and `@impl` should add runtime dependency

~Ah, passing a behaviour to `defoverridable/1` / `Module.make_overridable` will now have to introduce a compile-time dependency.~ Nevermind, it already has to...