inky-rb
inky-rb copied to clipboard
fix raw tag parsing to work for multi-line HTML
fixes raw tag parsing mentioned in #95
Interesting PR.
I only looked at it quickly and I'm not the final authority on this gem, but a few things come to mind:
-
this mixes independent changes (config vs
rawtag). Ideally these would be separate PRs. Also never change version numbers in a PR, that's the job of the maintainers. -
For the
rawtag, the issue I see is thatinky-rbis meant to be the Ruby port ofinky, so it should probably supportrawtags iffinkydoes. -
For the config part, I believe that ignoring bad values passed (e.g. test "will not set an invalid components override") is not the right way to go. Raise a
TypeErrorinstead.
@marcandre
-
good point, I will split it into separate PRs
-
this repo already supports raw tags, but the current implementation in this repo only checks a single line at a time. this is an HTML based library, that's not how users expect HTML parsing to work
-
another good point, will fix
- Oh, right, my bad.