Marc-André Lafortune

Results 450 comments of Marc-André Lafortune

Not yet, it is installing 9.2.16 right now.

I'm sorry you're having difficulty with the node patterns. There's certainly room for improvement in the docs. The doc you referred to is about the _compiler_, but you should look...

Heredocs are complicated. The notion of 'source' of a heredoc is strange as the source is disconnected. It's important to realize how disconnected it is... ```ruby foo(

Thanks for the ping, sorry I didn't answer before. I'm 👍 on `#first_line, `#last_line`, and (not present in this pr) `#line_count`, and anything else that can be useful to you...

We can consider `line_range` (instead?), and maybe they should be named `body_line_range` or `heredoc_line_range` to underline that it is the range of the text itself, not of the begin/end markers

You'll have to bump 0.92 => next RuboCop version (and we'll merge when it is released)

> @marcandre I guess we need a backport for v0.92 (or v0.93?) in order to make the tests there pass? I don't think we can do much tbh. It's ok,...

CI error is a fluke we can ignore.

Oh, indeed, it seems to be missing in the main doc 😅 PR welcome, or I'll handle it after Xmas

My fault btw, I was tired of the repetition between the source code's doc and the official doc, so I removed the code's doc in 2ca9c08 but didn't notice that...