Marc-André Lafortune comments

Results 470 comments of


                                            Marc-André Lafortune

Problem on Typespect with the arrow operator

Released v2.1.1 Thanks, and sorry again for the delay

Elixir 1.17 should provide better feedback on dead code

> I changed the title to reflect that the error is correct but the message is wrong. It should rather say about dead code. I'm trying to understand why the...

Elixir 1.17 should provide better feedback on dead code

Got it, thanks.

Enhancement: detect safe navigation in `Style/ReturnNilInPredicateMethodDefinition`

> I started looking into this but I'm not sure what the proper solution here would be. I was thinking the "good" case might be: > > ```ruby > def...

Some predicates return `nil`

First, I'm also planning on adding `def_node_predicate` that will generate code that always return a boolean. Now there are a bunch of issues. I note that the doc of `def_node_matcher`...

Some predicates return `nil`

> Would it be a syntax error if a `def_node_predicate` has captures? Very good point, I think it should > Making it a breaking change sounds right to me. Would...

How is Quill2.0 compatible?

Please consider: 1) Stating this in big letters at the very beginning of the README, and 2) Archiving the project.

Soft deprecation of the project?

I think the rewriter could definitely be included in `rubocop-ast`, or even better be a separate gem altogether.

Using captures in `?` with OR branches has an effect on captures outside the optional matching

Thanks for opening the issue. Yes, I agree that these patterns should all be valid and return the exact same results for any input.

`?` repetition causes matched nodes to be returned as an array

> Does my "complaint" make sense? It does. > Can't change this now without a major version bump of course Well, there's a major version in the works... :-)