Marc-André Lafortune

Results 450 comments of Marc-André Lafortune

I'll see what I can do. I agree with you that it should work out of the box as much as possible. I would alias `on_numblock` to `on_block`; cops that...

> Any ideas? Sorry, that's my code 😅 . It could be adapted so that it creates the right type of node, base on the existence of `VarNode` or not...?...

We need this exact same feature (also with `maxDepth = 2`). I coded it up, but this would be a nice feature to have. > The reason for not adding...

PS: This would also make the lib more robust. Currently, it's possible to drag a nested item from a group with `nested: true` to a group with `nested: false`. To...

@danielboendergaard the code doesn't always count the depth of `$item` correctly, in particular the following: ``` ol li ol li ol li ``` Here's the code to show that: http://jsfiddle.net/4ULSV/

Sorry you're having issues with this. Could you provide an example please? It's difficult to answer more precisely without one.

There's also [a request](https://github.com/rubocop-hq/rubocop/pull/8376#issuecomment-670428314) to have a list of accepted superclasse exceptions, would that resolve the issue for you? I'm curious of examples where there are good reasons to explicitly...

> I might have to navigate to another file to see what logic is happening there The idea is that if there was *no* `initialize` method, say, would you actually...

Not necessary, but can't hurt. I also don't think we are dealing with: ```ruby class Foo extend ModDependingOnInheritedCallback def self.inherited(base) super ``` or ```ruby # base.rb class Foo < Bar...

@nahaylo Argh, this PR turned out to be more work than anticipated. I haven't worked on it in a while. I add a bit more work done locally; I rebased...