Magnus Ihse Bursie
Magnus Ihse Bursie
If we are going to limit this to just allowing users to set font style in some way, I agree with ShadowCat that adding a function is a better option.
I'm not really up to date with the structure of the code in enough detail (perhaps a sign that I should stop medddling :-)) but I think what's needed is...
I looked through all changes. Most of them look like trivial refactorings on the part of vanilla. There were a few places where I raised my eyebrows, I've commented on...
Sorry, been out of the loop for a bit here. Sure, I can take a look at the font handling, I probably need to read up a bit on how...
The missing comma is a Wynncraft bug. But maybe Wynntils should be more tolerant for incorrect coordinates. We have a "sloppy" coordinates parser for chat messages, but quests require a...
I think we might need to work with this for a while to get it right. And be prepared that the first attempts will likely just be exploratory, and that...
Let's start with e.g. this: `String MARKER_PREFIX = "\uDAFF\uDFF8[\uE010-\uE014]\uDAFF\uDFDE";` It is just gibberish. You could probably not even tell which part of the code that it came from.
I have a thought that is kind of tangential to this, but how should we handle updates to Wynntils that require an update to Minecraft? We should perhaps not just...
I think this looks like a prudent solution. I am not part of the client team though, so don't count this as a formal review.
I'm trying to interpret what you are requesting in terms of Wynntils concepts. I believe you are asking for Wynntils to provide a way to translate: a) Stat names (like...