Magnus Ihse Bursie

Results 345 comments of Magnus Ihse Bursie

I struggled a long time getting access to ISOs not in the efi/boot folder. As the documentation said "relative", I thought a path like "../../_ISO/LINUX/ubuntu.iso" would do fine. It did...

The fix in numer 8 is broken, and has the potential to cause a new NPE further down. I'm curious as to why the bot thought that returning null would...

I think what you're doing is interesting, but you have a long way to go. (You probably realise this yourselves.) As for having multiple patches, and selecting the best --...

@aivanov-jdk While I approve of finding and fixing spelling mistakes, grammatical or semantic errors, the mistakes you posted suggestions for was not at all associated with the mechanical changes made...

Thank you bot. I'm on it!

I have now removed the changes to libfreetype, and also libjpeg. These were the only 3rd party source I could locate. I apologize for this PR. It was too huge....

/contributor add turbanoff

/contributor add @turbanoff

> Is `src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c` a third-party code? I don't think so. I find no comments in the source code, or any kind of indication on this being so. If you say...

I see now that Phil cryptically said: > Regarding changes in gif + freetype diff --git a/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c b/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c \ \ diff --git a/src/java.desktop/share/native/libfontmanager/freetypeScaler.c b/src/java.desktop/share/native/libfontmanager/freetypeScaler.c \ \ Please exclude ALL 3rd...