Magnus Ihse Bursie
Magnus Ihse Bursie
Hm. Not to dis all your work, but I think there are some issues with this implementation, where the most important is that it doe not show the tree nature...
And then you should be able to hide/show either individual nodes or entire subtrees. And also, be able to edit the categories like this -- either on a leaf or...
Let me illustrate with a screenshot from VS Code, I think that works better. Here subtrees can be collapsed/expanded, and icons are shown (as visual aid) for leaves. This image...
@ShadowCat117 Did you bisect down to confirm that it was that specific PR that caused the shaking effect to disappear? It seems completely unlikely; that PR is just about how...
No, that does not seem correct. I checked out 8a7f805d9f8127b1f2ece6dcc119ae013f415b95 and the weapon shakes properly.
No, I just did not reproduce correctly. It shakes even in `main`. It turns out that manually triggering a cast makes the weapon shake, it is the quick cast keybind...
I'm unable to reproduce the shaking effect in 3.2.2. When I go back this far, I can't quick cast since my weapon is not recognized as a weapon, and the...
Ok, I have now checked out 9dbf61f7639f15a10095e95c4c830f28da26587b (HEAD, tag: v3.2.2). I have patched the code to work despite json changes: ``` diff --git a/common/src/main/java/com/wynntils/models/wynnitem/AbstractItemInfoDeserializer.java b/common/src/main/java/com/wynntils/models/wynnitem/AbstractItemInfoDeserializer.java index 69868be1b..c9c52b08a 100644 --- a/common/src/main/java/com/wynntils/models/wynnitem/AbstractItemInfoDeserializer.java...
This seems interesting, but I have a bunch of questions/worries. Most of them are probably due to the fact that I've missed a lot of how Wynncraft has updated things....
Also, your example makes it clear that this functionality is severly less helpful without #3427: While `§{banner/ribbon}` might be good in that it actually *enables* users to get a banner,...