Magnus Ihse Bursie

Results 413 comments of Magnus Ihse Bursie

This is starting to look really, really good! I added two more point to the bullet list in the description. But I believe that is really the last part, then...

Does `chore: Rough merge of main` mean that the previous merge was incomplete, and that this commit fixes it, or that this commit is just a partial fix and more...

What is really remaining here? Is it the GUI part? (I've forgotten)

I'm not sure how VulkanMod works, but I assume it needs to support the same kind of rendering primitives that vanilla uses, with a drop-in API functionality. If so, it...

I introduced the "" label, but I only ever intended it to be a temporary thing to show that the detection of protection status was working or not. I agree...

My plan was to actually change the Overlay into a proper Screen when faced with a protected dialogue. That way, you would be able to click on the continue button...

Please feel free to take a stab at it. :) I imagine it will make a huge impact to the play feel of Wynncraft, to be able to click "Continue"...

``` // Check if the item is on a later or earlier page for (int i = 0; i < itemMap.size(); i++) { // Skip the current page if (i...

For the latter issue, WynntilsContainerScreen need to implement more methods as final and add a wrapped version. `mouseClicked`, dragged, scrolled, released etc as a minimum.

@AlanBateman I think what is holding this PR back is that you said you wanted to review it.