Magnus Ihse Bursie
Magnus Ihse Bursie
Fortunately, I think doing 2 is actually not that hard; most of the pieces are already in place, they just needs to be connected differently. I one big thing we...
I was also thinking, did we ever figure out the correct (or at least best) way of dealing with different override priority based on category inheritance and provider ordering? Basically,...
It seems you got most of it covered. Great work! I'm eternally grateful for your work @ShadowCat117 and @kristofbolyai in actually managing to get this to a deliverable state. Sorry...
> We go down until the most specific category. I've been using the "override provider" concept for a while now, which can provide attribute overrides that apply on top of...
I'm not sure if is 100% necessary that we get this right before releasing. We can probably change what in effect is some obscure ordering principles after release and it...
> > 3. Handling of mapdata providers > > I think we are still missing a mapdata provider management screen. [... ] > > (We might need to add some...
Actually, this comment from the PR description sounds like we are actually doing right now what I propose we do: > Figure out if we should change attribute resolving to...
You don't have to explain, it's on me to dig in and understand the code.
FWIW, I skimmed through all the changes in this entire PR. I think this mostly looks good and makes sense. (I'm glad we already had a baseline MapData implementation in...
And also, I think I understand the current override functionality, and I'm fine with it.