Magnus Ihse Bursie

Results 351 comments of Magnus Ihse Bursie

What is here was my first start. I don't think this went in a good direction but I also did not want to delete it. So I'm saving it in...

Yeah, you are right. But we need to have some kind of way to store the json files locally, and decide if and when to refresh the local copy form...

After sleeping on the matter, I definitely think what we should have is: 1) All online sources should have the possibility for a "manual refresh". 2) It should be possible...

We should support three kinds of providers: the built-in providers (possible exposed just as one), online sources, and local files. Local files can initially be just files picked up from...

And my final note here is that while a GUI is essential for all these operations, I also think we should have a command line interface for this. If for...

There are 123 calls to requestCancel(). I've tried to look at every one of them and asses that this is indeed what was meant, and that the intention was not...

We use events sometimes to indicate to our models that something has happened in Minecraft, and sometimes to stop things happening in Minecraft. We have used the Forge eventbus cancel...

> At least to me, 'cancel' equates to 'act like this never happened'. What is the "this" here? We are typically sending events as response to something happening in minecraft...

Let's hold this until we get the Chat Reborn PR merged then. I feel like I'm fixing every issue over and over again...

So I get this since loom adds a `genSourcesWithFernFlower` task? It seems like `genSources`, at least in my setup, executes the `genSourcesWithVineflower` task, so from my PoV making the IDEA...