Mike Drob

Results 72 comments of Mike Drob

My ideal world is everywhere that we remained -x to -y we add -y to 9.x and log a warning on usage of -x. Similar to what gradle does. But...

I tried to isolate this and it looks like something is happening in `testHighMinExactCountWithQueryResultCache` that is interfering with the other tests, like maybe it is inserting too many new cache...

Would it be more straightforward to use a solrconfig.xml that has auto warm count set to zero on the caches of interest?

I'm having trouble understanding how this is used in practice, can you add a unit test showing an example override implementation?

> I've placed use illustrations on the JIRA ticket, does that help? That's not to say we can't have unit test coverage too of course. Yea, those are helpful. Test...

I didn’t even consider the “quoted” case, I was thinking of text with a quote character in the middle. But I’m glad that we are thinking about that one too!

> perhaps any fix would be for 9x only and then no need to consider the scenario of the caller having added surrounding quotes since backwards compatibility is not retained...

Was recently reading the book, and ran into this same question! ![image](https://user-images.githubusercontent.com/1592330/118296939-23e7e100-b4a3-11eb-834c-db263d89b58f.png)

CircleCI build on large machine takes 7 minutes, while a build on medium machine is slightly longer at 9 minutes. However, the medium machine is significantly cheaper, still giving us...

Should have been marked ready a while ago. Please merge!