SOLR-14690: QueryResultKey.[nc_]minExactCount

[cpoerschke]

Allow with-minExactCount searches to use query cache entries from without-minExactCount searches.

https://issues.apache.org/jira/browse/SOLR-14690

(Transferred from draft https://github.com/apache/lucene-solr/pull/1530 pull request to here.)

[cpoerschke]

Via ./gradlew :solr:core:test --tests "org.apache.solr.search.SolrIndexSearcherTest" -Ptests.jvms=4 -Ptests.jvmargs=-XX:TieredStopAtLevel=1 -Ptests.seed=B773ACC2C581EBBA -Ptests.file.encoding=UTF-8 two tests fail, but running them individually does not reproduce. My initial suspicion would be interaction between the two tests.

ERROR: The following test(s) have failed:
  - org.apache.solr.search.SolrIndexSearcherTest.testLowMinExactCountWithQueryResultCache (:solr:core)
    Test output: /Users/cpoerschke/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.search.SolrIndexSearcherTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.search.SolrIndexSearcherTest.testLowMinExactCountWithQueryResultCache" -Ptests.jvms=4 -Ptests.jvmargs=-XX:TieredStopAtLevel=1 -Ptests.seed=B773ACC2C581EBBA -Ptests.file.encoding=UTF-8

  - org.apache.solr.search.SolrIndexSearcherTest.testMinExactCount (:solr:core)
    Test output: /Users/cpoerschke/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.search.SolrIndexSearcherTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.search.SolrIndexSearcherTest.testMinExactCount" -Ptests.jvms=4 -Ptests.jvmargs=-XX:TieredStopAtLevel=1 -Ptests.seed=B773ACC2C581EBBA -Ptests.file.encoding=UTF-8

[madrob]

I tried to isolate this and it looks like something is happening in testHighMinExactCountWithQueryResultCache that is interfering with the other tests, like maybe it is inserting too many new cache entries? For some reason the commit that happens in the setup() method might not be clearing the caches? Or auto warming settings are repopulating it?

[madrob]

Would it be more straightforward to use a solrconfig.xml that has auto warm count set to zero on the caches of interest?

[cpoerschke]

w.r.t. Solr Ref Guide content updating -- https://solr.apache.org/guide/8_9/common-query-parameters.html#minexactcount-parameter -- I've considered this but couldn't see an obvious way of reflecting this change and in a way it's implementation detail anyhow.

[github-actions[bot]]

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!