Mike Drob
Mike Drob
Thanks for contributing! I strongly prefer the allow list approach in #26 and will leave specific code feedback in that PR. However, that PR wouldn't have been possible without your...
One danger of leaking memory on close is that in the future it makes things like ValGrind less useful when chasing a runtime memory leak.
@JianyuWangV You may need to rebase your changes to get CI to run. Thanks!
This is fun!
We're on commons-io 2.15.1? We should upgrade to 2.16.1 in this PR, since you're already looking at it and I remember that some stream closing behavior changed between these two...
We're using `cimg/base:stable` which is two years old and a deprecated tag. Looking at `cimg/base:current` which is more recent, that still only includes bash 5.1.16 - is that new enough...
@davidkoski actions are enabled now, you might have to close and re-open the PR to get them to run the first time.
I think it's safe to delete the `.circleci` directory in this PR rather than waiting for the next one
@bioball Actions are currently disabled on the repo, but would it be useful to merge anyway so that other folks who are forking can run the tests? I wouldn't want...
Do we have input from the zookeeper community about their preferred or recommended approach?