Mike Drob
Mike Drob
This needs to be tested with docker containers before merging.
@risdenk I believe the issue currently is that for hadoop-auth we are not able to rely solely on `hadoop-client-*` dependencies, which are the ones that would use a relocated curator....
Relevant ideas from Mark's pass at this last year - https://github.com/markrmiller/solr/blob/reference_impl/solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java#L71-L97 I think there's actually a bug in _his_ code regarding interrupt, but I do like throwing an exception if...
Which version of Java were you testing this with?
I'm likely -1 on this patch based solely on the venerable Aleksey Shipilev post https://shipilev.net/jvm/anatomy-quarks/10-string-intern/
I suspect that we want to de-duplicate the keys but not the values? Do the values repeat across shards? Maybe we can identify a known set of duplicated strings and...
Was this measured using PRS or "traditional" state?
You are correct, a lot of the values are repeated too, whether they are booleans or enums, a lot of them are basically part of a closed set. Still, I...
Can you try running with the JVM option `-XX:+UseStringDeduplication` - that might handle this issue for you without the need for code change.
The failure is ``` /home/runner/work/solr/solr/solr/solrj/src/java/org/apache/solr/common/cloud/CompositeIdRouter.java:238: warning: [NarrowCalculation] This product of integers could overflow before being implicitly cast to a long. > Task :solr:solrj:compileJava boolean round = rangeStep >= (1